Hi Shannon, Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171214-150202 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master config: score-spct6600_defconfig (attached as .config) compiler: score-elf-gcc (GCC) 4.9.4 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=score All errors (new ones prefixed by >>): net/xfrm/xfrm_device.c: In function 'xfrm_dev_register': >> net/xfrm/xfrm_device.c:157:24: error: dereferencing pointer to incomplete >> type dev->xfrmdev_ops->xdo_dev_state_add && ^ net/xfrm/xfrm_device.c:158:24: error: dereferencing pointer to incomplete type dev->xfrmdev_ops->xdo_dev_state_delete)) { ^ vim +157 net/xfrm/xfrm_device.c 144 145 static int xfrm_dev_register(struct net_device *dev) 146 { 147 if (!(dev->features & NETIF_F_HW_ESP)) { 148 if (dev->features & NETIF_F_HW_ESP_TX_CSUM) { 149 netdev_err(dev, "NETIF_F_HW_ESP_TX_CSUM without NETIF_F_HW_ESP\n"); 150 return NOTIFY_BAD; 151 } else { 152 return NOTIFY_DONE; 153 } 154 } 155 156 if (!(dev->xfrmdev_ops && > 157 dev->xfrmdev_ops->xdo_dev_state_add && 158 dev->xfrmdev_ops->xdo_dev_state_delete)) { 159 netdev_err(dev, "add or delete function missing from xfrmdev_ops\n"); 160 return NOTIFY_BAD; 161 } 162 163 return NOTIFY_DONE; 164 } 165 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
