On 09/02/2017 10:47 AM, Andrew Lunn wrote: > On Sat, Sep 02, 2017 at 09:32:08AM -0700, Florian Fainelli wrote: >> >> >> On 09/02/2017 09:30 AM, Andrew Lunn wrote: >>>> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, >>>> int port) >>>> reg |= MII_DUMB_FWDG_EN; >>>> core_writel(priv, reg, CORE_SWITCH_CTRL); >>>> >>>> + /* Configure Traffic Class to QoS mapping, allow each priority to map >>>> + * to a different queue number >>>> + */ >>>> + reg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port)); >>>> + for (i = 0; i < 8; i++) >>>> + reg |= i << (PRT_TO_QID_SHIFT * i); >>> >>> Hi Florian >>> >>> Rather than 8, would ds->num_tx_queues be more descriptive? >> >> I actually have a patch on top of this which defines a constant for the >> number of queues instead of open coding 8 here. Thanks! > > Hi Florian > > It sounds like it should be part of 3/4?
Right, let me re-submit with that change included. Thanks -- Florian