Edgar E. Iglesias <[EMAIL PROTECTED]> wrote: > > Not sure what you mean with "most of the time" but a while a go I played > around with a something like this for another driver. The tx path was > cleaning > up the tx ring at certain intervals while the tx irq-handler was not touching > the ring unless it had become full. Actually the tx irq was disabled most of > the time and ring manipulation became simpler.
Yes that's exactly what I mean :) > Later I ended up throwing this away as it was causing some TCP connections to > deadlock. If you let skb's sit in the tx-ring indefintely, the > sk->sk_wmem_queued accounting will be inacurate and this was causing the TCP > retransmit logic to deadlock. Yes you need to clean the ring if the TX queue becomes empty or you'll risk dead locks. What driver was this and did you do any performance measurements? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
