On Sun, Aug 06, 2006 at 12:51:23PM +1000, Herbert Xu wrote: > > I wonder if we could do the TX clean up within the transmission > routine most of the time. Has anyone tried this before? >
Hi Herbert, Not sure what you mean with "most of the time" but a while a go I played around with a something like this for another driver. The tx path was cleaning up the tx ring at certain intervals while the tx irq-handler was not touching the ring unless it had become full. Actually the tx irq was disabled most of the time and ring manipulation became simpler. Later I ended up throwing this away as it was causing some TCP connections to deadlock. If you let skb's sit in the tx-ring indefintely, the sk->sk_wmem_queued accounting will be inacurate and this was causing the TCP retransmit logic to deadlock. Again, I'm not sure what you mean with "most of the time" but if you make sure the tx-ring is continously beeing cleaned-up, even tough no more packets are beeing generated, maybe it could work. I hope this wasn't completely irrelevant.. Best regards, -- Programmer Edgar E. Iglesias <[EMAIL PROTECTED]> 46.46.272.1946 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html