On Mon, Jul 24, 2017 at 03:48:40PM +0200, Antoine Tenart wrote: > This patch adds the GoP link interrupt support for when a port isn't > connected to a PHY. Because of this the phylib callback is never called > and the link status management isn't done. This patch use the GoP link > interrupt in such cases to still have a minimal link management. Without > this patch ports not connected to a PHY cannot work.
Hi Antoine When is a GoP link interrupt signalled? When is a port without a PHY actually up/down? With SFF/SFP ports, you generally need a gpio line the fibre module can use to indicate if it has link. Fixed-phy has such support, and your link_change function will get called when the link changes. And this is another bit of code you probably need to change in a while with phylink lands. Andrew