Hello,

On Mon, 24 Jul 2017 15:48:40 +0200, Antoine Tenart wrote:
> +
> +             port->link_irq = of_irq_get_byname(port_node, "link");
> +             if (port->link_irq == -EPROBE_DEFER) {
> +                     err = -EPROBE_DEFER;
> +                     goto err_free_irq;
> +             }
> +             if (port->link_irq <= 0)
> +                     /* the link irq is optional */
> +                     port->link_irq = 0;

You need to add the irq_dispose_mapping() call corresponding to this
of_irq_get_by_name() in the error path and in the remove path.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Reply via email to