jamal <[EMAIL PROTECTED]> wrote: > > There is no need for tx_locking if you are already netif stopped > (transmit path will never be entered). > With this change under high speed forwarding i see anywhere > between 2-4Kpps improvement on a 2 CPU environment with twoo e1000s tied > to different CPUs forwarding between each other. Actually the > performance improvement should be attributed to the use of > TX_WAKE_THRESHOLD - more drivers should use that technique.
Looks good to me. Even if we get it wrong and wake up something that we shouldn't have, the xmit function will simply bail out and stop the queue for us. Since this is exceedingly unlikely we should drop the locks rather than bother about it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
