On Wed, 21 Jun 2017 16:04:44 +0300 Gal Pressman <g...@mellanox.com> wrote:
> + > +enum { > + ETHTOOL_LINK_VENDOR_SPECIFIC = -1, /* Vendor specific issue provided in > vendor_reason */ > + ETHTOOL_LINK_NO_ISSUE, /* No issue observed with link */ > + ETHTOOL_LINK_REASON_UNKNOWN, /* Unknown reason */ > + ETHTOOL_LINK_NETDEV_CARRIER_DOWN, /* Netdev carrier is down */ > + ETHTOOL_LINK_ADMIN_DOWN, /* Admin down */ > + ETHTOOL_LINK_AN_FAILED, /* Auto negotiation failed */ > + ETHTOOL_LINK_TRAINING_FAILED, /* Link training failed */ > + ETHTOOL_LINK_RMT_FAULT, /* Remote fault indication */ > + ETHTOOL_LINK_BAD_SIGNAL_INTEGRITY, /* Bad signal integrity */ > + ETHTOOL_LINK_CABLE_MISMATCH, /* Cable protocol mismatch */ > + ETHTOOL_LINK_INTERNAL_ERR, /* Internal error */ > + ETHTOOL_LINK_CABLE_UNPLUGGED, /* Cable unplugged */ > + ETHTOOL_LINK_UNSUPP_MODULE, /* Unsupported module */ > + ETHTOOL_LINK_I2C_BUS_ERR, /* I2C bus error */ > + ETHTOOL_LINK_UNSUPP_EEPROM, /* Unsupported EEPROM */ > + ETHTOOL_LINK_OVERTEMP, /* Over temperature */ > + ETHTOOL_LINK_PWR_BUDGET_EXC, /* Power budget exceeded */ > + ETHTOOL_LINK_MODULE_ADMIN_DOWN, /* Module admin down */ > + > + ETHTOOL_LINK_REASONS_COUNT > +}; Any enumerated list is going to get changed too often. Could the API just return a string?