On 5/25/17 9:31 AM, Vladislav Yasevich wrote: > Whenever a user changes bonding options, a NETDEV_CHANGEINFODATA > notificatin is generated which results in a rtnelink message to > be sent. While runnig 'ip monitor', we can actually see 2 messages, > one a result of the event, and the other a result of state change > that is generated bo netdev_state_change(). However, this is not > always the case. If bonding changes were done via sysfs or ifenslave > (old ioctl interface), then only 1 message is seen. > > This patch removes duplicate messages in the case of using netlink > to configure bonding. It introduceds a separte function that > triggers a netdev event and uses that function in the syfs and ioctl > cases. > > This was discovered while auditing all the different envents and > continues the effort of cleaning up duplicated netlink messages. > > Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> > --- > drivers/net/bonding/bond_main.c | 3 ++- > drivers/net/bonding/bond_options.c | 27 +++++++++++++++++++++++++-- > include/net/bond_options.h | 2 ++ > 3 files changed, 29 insertions(+), 3 deletions(-)
LGTM Acked-by: David Ahern <dsah...@gmail.com>
