Fri, Apr 28, 2017 at 03:42:31PM CEST, j...@mojatatu.com wrote: >On 17-04-28 09:21 AM, Jiri Pirko wrote: >> Fri, Apr 28, 2017 at 02:30:17PM CEST, j...@mojatatu.com wrote: >> > On 17-04-28 03:02 AM, Jiri Pirko wrote: >> > > Fri, Apr 28, 2017 at 03:22:53AM CEST, j...@mojatatu.com wrote: >> > >> > [..] >> > > > Maybe I am misunderstanding: >> > > > Recall, this is what it looks like with this patchset: >> > > > <nlh><subsytem-header>[TCA_ROOT_XXXX] >> > > > >> > > > TCA_ROOT_XXX is very subsystem specific. classifiers, qdiscs and many >> > > > subsystems defined their own semantics for that TLV level. This >> > > > specific >> > > > "dump max" is very very specific to actions. They were crippled by the >> > > > fact you could only send 32 at a time - this allows more to be sent. > >> > > >> > > All I suggest is to replace NLA_U32 flags you want that does not >> > > have any semantics with NLA_FLAGS flags, which eventually will carry >> > > the exact same u32, but with predefined semantics, helpers, everything. >> > > >> > >> > I didnt understand fully Jiri. Are you suggesting a new type called >> > NLA_FLAGS which is re-usable elsewhere? >> >> Exactly. That's what I'm saying. >> > >If you want to make it general: >I see the semantics of this thing as more detailed than what I had. >It would have a u32 bitmap + u32 bitmask.
Sure, lets make this nice.
