Fri, Apr 28, 2017 at 02:55:40PM CEST, j...@mojatatu.com wrote: >On 17-04-28 08:21 AM, Simon Horman wrote: >> On Wed, Apr 26, 2017 at 10:46:58AM -0400, David Miller wrote: >> > From: Jiri Pirko <j...@resnulli.us> >> > Date: Wed, 26 Apr 2017 15:05:06 +0200 >> > > >[..] >> > > Should be part of UAPI as well >> > > I see that include/uapi/rdma/vmw_pvrdma-abi.h is using BIT macro. >> > > I don't see BIT macro defined in UAPI (I thought it is). So either >> > > define it there (not sure where) or just use "<<" >> > >> > "BIT" is a pretty crazy small simple name to pollute into the global >> > namespace, IMHO. >> >> It sounds to me that it would be best to just use "<<" rather than >> spending cycles posturing on how to add it to the UAPI. Existing users >> of BIT in the UAPI could also be updated to use "<<" to avoid having >> a misleading precedence in-tree. >> > >We need to convince Jiri ;-> He has plans to do a lot of cleanups and >I feel like I am pioneering (A lot of new things on my patchset). >Jiri, could this come in your cleanups later? Sure.
> >cheers, >jamal
