> On Feb 6, 2017, at 11:15 PM, Joe Stringer <j...@ovn.org> wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme <ja...@ovn.org> wrote: >> struct sw_flow_key has two 16-bit holes. Move the most matched >> conntrack match fields there. In some typical cases this reduces the >> size of the key that needs to be hashed into half and into one cache >> line. >> >> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > > Looks like this misses the zeroing in ovs_nla_get_flow_metadata(); > might want to double-check for any other memset/copies of the key->ct > field.
Good catch. Looked, there are no other places to change. Will rebase to current net-next and repost. Jarno
