On 6 February 2017 at 23:15, Joe Stringer <j...@ovn.org> wrote: > On 2 February 2017 at 17:10, Jarno Rajahalme <ja...@ovn.org> wrote: >> @@ -79,9 +80,17 @@ static inline void ovs_ct_fill_key(const struct sk_buff >> *skb, >> key->ct.zone = 0; >> key->ct.mark = 0; >> memset(&key->ct.labels, 0, sizeof(key->ct.labels)); >> + key->ct.orig_proto = 0; >> + key->ct.orig_tp.src = 0; >> + key->ct.orig_tp.dst = 0; >> + if (key->eth.type == htons(ETH_P_IP)) >> + memset(&key->ipv4.ct_orig, 0, sizeof(key->ipv4.ct_orig)); >> + else if (key->eth.type == htons(ETH_P_IPV6) && >> !sw_flow_key_is_nd(key)) >> + memset(&key->ipv6.ct_orig, 0, sizeof(key->ipv6.ct_orig)); > > If we only ever use these fields based on key->ct.orig_proto being > nonzero, then we m
I think I had my email opened in two windows so truncated this sentence somehow. I was wondering whether we can just initialize key->ct.orig_proto and only init the others on demand.
