Wed, Nov 16, 2016 at 09:43:15AM CET, green...@gmail.com wrote: >To support device tree usage for ftmac100. > >Signed-off-by: Greentime Hu <green...@gmail.com> >--- > drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/drivers/net/ethernet/faraday/ftmac100.c >b/drivers/net/ethernet/faraday/ftmac100.c >index dce5f7b..81dd9e1 100644 >--- a/drivers/net/ethernet/faraday/ftmac100.c >+++ b/drivers/net/ethernet/faraday/ftmac100.c >@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct >platform_device *pdev) > return 0; > } > >+static const struct of_device_id mac_of_ids[] = {
Prefix of everything in this file is "ftmac100", yet here, you use "mac". I wonder why?!? >+ { .compatible = "andestech,atmac100" }, >+ { } >+}; >+ > static struct platform_driver ftmac100_driver = { > .probe = ftmac100_probe, > .remove = __exit_p(ftmac100_remove), > .driver = { > .name = DRV_NAME, >+ .of_match_table = mac_of_ids > }, > }; > >@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void) > MODULE_AUTHOR("Po-Yu Chuang <ratb...@faraday-tech.com>"); > MODULE_DESCRIPTION("FTMAC100 driver"); > MODULE_LICENSE("GPL"); >+MODULE_DEVICE_TABLE(of, mac_of_ids); >-- >1.7.9.5 >