Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi

[Sergei Shtylyov]

On 10/05/2016 03:46 PM, Nelson Chang wrote:

+static bool mtk_is_hwlro_supported(struct mtk_eth *eth) {
+     if (eth->chip_id == MT7623_ETH)
+             return true;
+     else
+             return false;

        return eth->chip_id == MT7623_ETH;

=> Since there will be more chips support hw lro in the future, keep the
original codes to have the scalability like this:
if (eth->chip_id == MTxxxx_ETH ||
    eth->chip_id == MTyyyy_ETH ||
    ....)
        return true;

   Then use *switch*, not *if*.

Nelson

MBR, Sergei