On Tue, 21 Jun 2016 20:38:24 -0700
David Ahern <d...@cumulusnetworks.com> wrote:
> Extract parsing of sockstat and filter from inet_show_sock.
> While moving run_ssfilter into callers of inet_show_sock enable
> userspace filtering before the kill.
>
> Signed-off-by: David Ahern <d...@cumulusnetworks.com>
I would add this but it has checkpatch style issues
WARNING: braces {} are not necessary for any arm of this statement
#65: FILE: misc/ss.c:2060:
+ if (s->local.family == AF_INET) {
[...]
} else {
[...]
WARNING: line over 80 characters
#80: FILE: misc/ss.c:2070:
+static int inet_show_sock(struct nlmsghdr *nlh, struct sockstat *s, int
protocol)
ERROR: do not use assignment in if condition
#129: FILE: misc/ss.c:2295:
+ if ((err = inet_show_sock(h, &s, diag_arg->protocol)) < 0)
