Hi We will consider moving vpd_data out of stack. We will wait for few more time for other review comment, and submit one more patch on top of 5th patch addressing all review comments.
If there are no further comments please apply the patches 1 to 5 and notify us. We will submit one more patch which addressing all review comments. Thanks Ananda -----Original Message----- From: Francois Romieu [mailto:[EMAIL PROTECTED] Sent: Saturday, April 22, 2006 2:28 AM To: Ananda Raju Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [patch 2/5] s2io driver updates Ananda Raju <[EMAIL PROTECTED]> : [...] > Signed-off-by: Ananda Raju <[EMAIL PROTECTED]> > --- > diff -upNr perf_fixes/drivers/net/s2io.c dmesg_param_fixes/drivers/net/s2io.c > --- perf_fixes/drivers/net/s2io.c 2006-04-13 08:02:56.000000000 -0700 > +++ dmesg_param_fixes/drivers/net/s2io.c 2006-04-13 09:08:22.000000000 -0700 [...] > @@ -4626,6 +4633,45 @@ static int write_eeprom(nic_t * sp, int > return ret; > } > > +static void s2io_vpd_read(nic_t *nic) > +{ > + u8 vpd_data[256],data; You may consider removing vpd_data from the stack and kmallocing it. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
