Hi, Currently the only way we can differentiate between copper CX4 transponder adapters from optical transponder adapters is by reading the product name string in vpd.
Actually we added the VPD read function for identifying CX4 adapter. While submitting the patch the CX4 changes went in patch 3 and reading of vpd went in patch 2. Also we have one more product Xframe-E which is a PCIe adapter. This also has same device ID of Xframe-II PCI-X adapter. As we have multiple product with same Device_ID and only way to differentiate between them is through VPD string we are reading VPD string in driver. Thanks Ananda. -----Original Message----- From: Stephen Hemminger [mailto:[EMAIL PROTECTED] Sent: Monday, April 24, 2006 10:22 AM To: Francois Romieu Cc: Ananda Raju; [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [patch 2/5] s2io driver updates On Sat, 22 Apr 2006 11:28:02 +0200 Francois Romieu <[EMAIL PROTECTED]> wrote: > Ananda Raju <[EMAIL PROTECTED]> : > [...] > > Signed-off-by: Ananda Raju <[EMAIL PROTECTED]> > > --- > > diff -upNr perf_fixes/drivers/net/s2io.c dmesg_param_fixes/drivers/net/s2io.c > > --- perf_fixes/drivers/net/s2io.c 2006-04-13 08:02:56.000000000 -0700 > > +++ dmesg_param_fixes/drivers/net/s2io.c 2006-04-13 09:08:22.000000000 -0700 > [...] > > @@ -4626,6 +4633,45 @@ static int write_eeprom(nic_t * sp, int > > return ret; > > } > > > > +static void s2io_vpd_read(nic_t *nic) > > +{ > > + u8 vpd_data[256],data; > > You may consider removing vpd_data from the stack and kmallocing it. > Since there lsvpd tool doesn't in user space, why add more kernel code to do it? Adding more code to just print prettier console log's is bogus. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
