On Tuesday 26 April 2016 16:48:33 Saeed Mahameed wrote:
> >  }
> >
> > -static void mlx5e_build_channel_param(struct mlx5e_priv *priv,
> > -                                     struct mlx5e_channel_param *cparam)
> > +static struct mlx5e_channel_param *mlx5e_build_channel_param(struct 
> > mlx5e_priv *priv)
> 
> I prefer to keep the function prototype as before and move the dynamic
> allocation to mlx5e_open_channels,
> to keep alloc/free symmetric in mlx5e_open_channels.
> 
> 

Sure, do you want to just edit this when you forward the patch, or
do you need me to do it?

        Arnd

Reply via email to