sent updated version. commit description should have the details. what we are doing there is mimic what some others are doing, such as udp.c: when returning -ENOIOCTLCMD, net/core would fallback to dev_ioctl, which implements the NIC driver ioctls, which include ethtool ioctl.
On Sun, Mar 20, 2016 at 10:31 AM, David Miller <da...@davemloft.net> wrote: > From: David Decotigny <ddeco...@gmail.com> > Date: Thu, 17 Mar 2016 17:03:54 -0700 > >> This removes the requirement that ethtool be tied to the support >> of a specific L3 protocol, also updates a comment. > > You're adding an ioctl handler to netlink sockets, and it is not > at all apparent to me how this influences ethtool handling at all. > > Therefore you have to explain this here and in your commit message.