On Thu, 2016-03-17 at 17:03 -0700, David Decotigny wrote: > From: David Decotigny <de...@googlers.com> > > Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in > ETHTOOL_GLINKSETTINGS response to wrong nwords") > > Signed-off-by: David Decotigny <de...@googlers.com>
Reviewed-by: Ben Hutchings <b...@decadent.org.uk> > --- > include/uapi/linux/ethtool.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index 2835b07..9222db8 100644 > --- a/include/uapi/linux/ethtool.h > +++ b/include/uapi/linux/ethtool.h > @@ -1648,9 +1648,9 @@ enum ethtool_reset_flags { > * %ETHTOOL_GLINKSETTINGS: on entry, number of words passed by user > * (>= 0); on return, if handshake in progress, negative if > * request size unsupported by kernel: absolute value indicates > - * kernel recommended size and cmd field is 0, as well as all the > - * other fields; otherwise (handshake completed), strictly > - * positive to indicate size used by kernel and cmd field is > + * kernel expected size and all the other fields but cmd > + * are 0; otherwise (handshake completed), strictly positive > + * to indicate size used by kernel and cmd field stays > * %ETHTOOL_GLINKSETTINGS, all other fields populated by driver. For > * %ETHTOOL_SLINKSETTINGS: must be valid on entry, ie. a positive > * value returned previously by %ETHTOOL_GLINKSETTINGS, otherwise -- Ben Hutchings Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
signature.asc
Description: This is a digitally signed message part