On Wed, Feb 15, 2006 at 09:34:23AM +0200, Ilia Sotnikov wrote: > > In some cases the patch could led to a large number of lookups on > rt_hash_code over all possible TOS values (additional 8 passes). In > complex configurations with many routing tables it could be > computationally expensive. That's why I left the original behaviour of > the patch - the possibility to revert back to the old way.
I don't think this is a good reason for having inconsistent and buggy behaviour. How about dropping TOS from the hash code instead? How many people out there actually route using the TOS and use more than two TOS values? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
