Hi Andrew, On Wed, 15 Feb 2006, Andrew Morton wrote: > Problem is, it doesn't resume correctly either with or without the patch: > it needs rmmod+modprobe to get it going again. (Which is better than the > aic7xxx driver, which has a coronary and panics the kernel on post-resume > reboot).
Hmm. Either I am totally confused or we don't even attempt suspend/resume for eisa and mca bus devices. Care to try this patch? Pekka Index: 2.6/drivers/eisa/eisa-bus.c =================================================================== --- 2.6.orig/drivers/eisa/eisa-bus.c +++ 2.6/drivers/eisa/eisa-bus.c @@ -128,9 +128,31 @@ static int eisa_bus_match (struct device return 0; } +static int eisa_bus_suspend(struct device * dev, pm_message_t state) +{ + int ret = 0; + + if (dev->driver && dev->driver->suspend) + ret = dev->driver->suspend(dev, state); + + return ret; +} + +static int eisa_bus_resume(struct device * dev) +{ + int ret = 0; + + if (dev->driver && dev->driver->resume) + ret = dev->driver->resume(dev); + + return ret; +} + struct bus_type eisa_bus_type = { .name = "eisa", .match = eisa_bus_match, + .suspend = eisa_bus_suspend, + .resume = eisa_bus_resume, }; int eisa_driver_register (struct eisa_driver *edrv) Index: 2.6/drivers/mca/mca-bus.c =================================================================== --- 2.6.orig/drivers/mca/mca-bus.c +++ 2.6/drivers/mca/mca-bus.c @@ -63,9 +63,32 @@ static int mca_bus_match (struct device return 0; } +static int mca_bus_suspend(struct device * dev, pm_message_t state) +{ + int ret = 0; + + if (dev->driver && dev->driver->suspend) + ret = dev->driver->suspend(dev, state); + + return ret; +} + +static int mca_bus_resume(struct device * dev) +{ + int ret = 0; + + if (dev->driver && dev->driver->resume) + ret = dev->driver->resume(dev); + + return ret; +} + + struct bus_type mca_bus_type = { .name = "MCA", .match = mca_bus_match, + .suspend = mca_bus_suspend, + .resume = mca_bus_resume, }; EXPORT_SYMBOL (mca_bus_type); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html