Horms <[EMAIL PROTECTED]> wrote: > >> Looks bogus to me. Why are we removing linux/modules.h from ip_vs_app.c >> when it uses things like EXPORT_SYMBOL? > > Given that the code still compiles, I guess linux/modules.h is included > in some other header that is included. I'm happy to put linux/modules.h > back in. Do you have any more suggestions?
This is the wrong way to go about it. You should never rely on indirect inclusions because they might be removed one day and your file will not compile anymore. The correct way to go about this is to go through each included header file and check if any of its symbols are used in the source file. Or if this is too tedious just leave it alone. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
