On Fri, Jan 27, 2006 at 07:33:24AM +1100, herbert wrote: > > > That breaks because of the race (found by Xen) where an interface > > is being deleted from a bridge and the device is being removed. > > > > br_del_if > > rmmod device > > netlink event > > br_device_event > > ... > > Sorry, I don't get it. How does adding a barrier in del_nbp > fix this bug? > > In fact, as far as I can see, you need to add a pair of > rcu_read_lock/rcu_read_unlock in br_device_event to make it > work.
Actually, this race shouldn't exist anyway because both br_del_if and br_device_event are meant to be called under the RTNL. So what's going on here? -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
