On Tue, Jan 31, 2006 at 02:41:13PM -0800, Stephen Hemminger wrote: > This is a simpler fix for the two races in bridge device removal. > The Xen race of delif and notify is managed now by a new deleted flag. > No need for barriers or other locking because of rtnl mutex. > > The del_timer_sync()'s are unnecessary, because br_stp_disable_port > delete's the timers, and they will finish running before RCU callback. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Nice work. I hope this goes into the tree soon. BTW, can NF_BR_PRE_ROUTING return with NF_QUEUE? If it can, then we'll need to recheck the validity of br_port in br_handle_frame_finish. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
