On Thu, Jan 19, 2006 at 09:57:24PM -0500, John W. Linville wrote:
> On Mon, Dec 05, 2005 at 06:48:15PM -0800, Jean Tourrilhes wrote:
> > On Mon, Dec 05, 2005 at 03:51:36PM -0800, jt wrote:
> > > Adrian Bunk wrote :
> > > >
> > > > Using WIRELESS_EXT instead of CONFIG_NET_RADIO is simply ugly.
> > >
> > > You are probably right that something need to be done about
> > > it, but I believe this is the wrong direction. I would prefer you to
> > > replace WIRELESS_EXT with CONFIG_WIRELESS_EXT.
> > >
> > [...]
> >
> > Less talk, more patches. What do you guys think of the
> > attached patch. Please try it...
>
> Did we get agreement/resolution on this topic? Are people happy with
> the patch?
>
> It seems like I saw some discussion recently on the nuances between
> using "select" and "depends on" in Kconfig files. I'm not sure this
> is doing the intended thing?
>
> (Patch is available here --
> http://marc.theaimsgroup.com/?l=linux-netdev&m=113383919303428&w=2)
>
> John
I remembert that Adrian had some comments on the fact that
CONFIG_WIRELESS_EXT was a 'visible' option, and wanted it to be
invisible. I told him to go ahead with the patch, so you may want to
ask him for all the details.
It looks like the end of the thread did not make it to the
archive, here was what was said :
-------------------------------------------------------
On Tue, Dec 06, 2005 at 10:04:13AM -0800, Jean Tourrilhes wrote:
> On Tue, Dec 06, 2005 at 04:25:14AM +0100, Adrian Bunk wrote:
> >
> > Looks good, two comments:
> > - why is WIRELESS_EXT a user-visible option?
>
> Is it possible to make it a non-visible option ? I personally
> don't know how to do that.
If you don't add a string after the bool/tristate, an option is
non-visible.
IOW:
config WIRELESS_EXT
bool
> If you prefer to make it a non-visible option, please go for
> it. Don't forget to revert back the help section in title into
> NET_RADIO.
Why?
> > - with this change, we do no longer have to #ifdef-guard #include's
>
> Hu ? I personally did keep the #ifdef around #include. Not
> including file make compilation faster, I believe. If you don't like
> it, please change it.
In the kernel, #include's are usually not #ifdef-guarded.
The effect on compile time is nearly zero.
Advantages of removing the #ifdef's:
- better readability
- less likely compile breakages with different .config's
> My first patch was more a proof of concept to get the ball
> rolling and gather feedback. As you feel strongly about it, you may
> want to go ahead with the patch.
OK.
cu
Adrian
-------------------------------------------------------
Have fun...
Jean
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
