Roberto Nibali wrote:

Hmmm, most (if not all) of those you get using netlink, like so for example:

ip -s -s link show dev eth0

But I see the incentive to add those to ethtool as well.

Yes, I think you can get everything out of netlink..but I find
the ethtool API much easier to use...

+ * set_rx_all: Set or clear IFF_ACCEPT_ALL_FRAMES, see if.h
+ * get_rx_all: Return 1 if set, 0 if not.
+ * set_save_fcs: Set or clear IFF_SAVE_FCS, see if.h
+ * get_save_fcs: Return 1 if set, 0 if not.


Something we would like to have in the standard kernel?

I'd love to see them in the kernel..I have cooresponding patches
for e100 and e1000 to support these features as well.  However,
the e1000 maintainers were not interested last I checked...

Thanks for this patch, I wonder if this should be integrated into ethtool per default?

Again..I'd love to see it in....

Ben

--
Ben Greear <[EMAIL PROTECTED]>
Candela Technologies Inc  http://www.candelatech.com

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to