Hmmm, most (if not all) of those you get using netlink, like so for example:

ip -s -s link show dev eth0

But I see the incentive to add those to ethtool as well.

Yes, I think you can get everything out of netlink..but I find
the ethtool API much easier to use...

I envision one tool to configure network related things through all OSI layers one day ;). The netlink API is not simple at first sight, however offers much benefit in long terms, I believe.

+ * set_rx_all: Set or clear IFF_ACCEPT_ALL_FRAMES, see if.h
+ * get_rx_all: Return 1 if set, 0 if not.
+ * set_save_fcs: Set or clear IFF_SAVE_FCS, see if.h
+ * get_save_fcs: Return 1 if set, 0 if not.

Something we would like to have in the standard kernel?

I'd love to see them in the kernel..I have cooresponding patches
for e100 and e1000 to support these features as well.  However,
the e1000 maintainers were not interested last I checked...

I reckon we have new e1000 maintainers :). Is a 2.6.x version ready?

On the longer run, well, the IFF_ACCEPT_ALL_FRAMES to me right now is more of academic (pktgen et al) value and regarding IFF_SAVE_FCS I'm not sure how people would use it. I don't see how not having IFF_ACCEPT_ALL_FRAMES would reap VLAN/priority information? Wouldn't this be a bug in tcpdump? Also how does the frame accounting work using this flag? Bad frames are still incremented in the stats, despite the kernel handling those frames.

Regarding IFF_SAVE_FCS I could see a problem with handling the skb for NICs that do no have this flag set. It would break horribly or you would need to invent IFF_SEND_ALL_FRAMES.

Slightely OT: What's the status of your VLAN MAC work? Is this for submission as well?

Thanks for this patch, I wonder if this should be integrated into ethtool per default?

Again..I'd love to see it in....

Meanwhile I've found your work on your OSS part of candelatech. Very interesting to me.

Cheers,
Roberto Nibali, ratz
--
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to