On Mon, 2 Jan 2006 16:11:36 +0100, Ivo van Doorn wrote:
> I was wondering about the ieee80211_hw->tx() method, perhaps I have missed 
> something
> in the ieee80211 code, but MGMT frames are not indicated as a seperate field 
> or queue right?
> RT2x00 has for example besides the TX ring the PRIO ring which is intended 
> for MGMT frames
> to be send with a higher priority then regular TX.
> Should each packet be checked for being a management frame and put to the 
> seperate queue,
> or should an attempt be made to make this PRIO ring a higher priority TX ring 
> which will
> allow regular TX frames to be send with that ring as well.

Just set ieee80211_hw->queues to the total number of rings and use the
ring according to ieee80211_tx_control->queue. The stack will choose the
best queue to use (if not today then in future).

> Another thing I notice was that fragments are handed 1 frame at a time, but 
> making the device
> kick the TX-ring after each frame. Shouldn't for fragmented frames the ring 
> be kicked after the
> last fragment has been given to the device?

Good question. It should be guaranteed that no other frame is sent to
the driver in between two fragments. So you can kick the DMA only if
WLAN_FC_MOREFRAG is not set in the FC. I'm not sure if this should be
automated somehow by the stack.

> In the configuration the antenna_sel value is not really clear to me.
> The options are Diversity, Ant0 en Ant1 which is clear,  but would this value 
> be applied to TX or RX antenna?
> It might be Ralink specific but in those devices the RX and TX antenna can 
> both be configured.

I think it is primary intended for TX antenna. Hostap driver has
separate fields (and ioctls) for TX and RX antenna but it seems it
didn't make its way to the dscape stack. It should be probably added.

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to