On Mon, 2006-01-02 at 15:43 +0100, Jiri Benc wrote:

> My todo list currently starts with these items:
> 

How about
 - get rid of all the embedded algorithms (AES, Michael, RC4,
   CRC) and use the crypto layer from the kernel
 - port IPW drivers instead of just moving everything around,
   get rid of old code completely
 - split out frame crypto stuff into modules like ieee80211 does
   (or maybe even use those?)
and finally
 - fix tabs vs spaces all over the place ;)

I also have a couple of questions:

It seems that all packets are tried to decrypt with all possible
algorithms, or is that just my misunderstanding of the code? Wouldn't it
be possible to know what to expect and only pass it through those
functions that are needed?

What's with CONFIG_OAP_LEDS_WLAN? Shouldn't that LED handling function
be a pointer that can be assigned to whatever one wants, and you could
then get rid of IEEE80211_LEDS etc?

This may be related to your item about reducing the number of
interfaces, but why do you have vlan interfaces explicitly? Shouldn't
the generic vlan code be able to handle this?

Thanks,
johannes

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to