jamal <[EMAIL PROTECTED]> writes: >> This bit alone doesn't tell if it's dormant or, for example, simply down >> (either admin or carrier).
> dormant is an operational state and _not_ an admin state. And, in your opinion, changing admin state has not effect on operational state? > How is this different from say a link flip-flopping? It is. Thomas or Stefan will probably explain it to you in details, I'm too tired. > Which is something > that could happen today even without these changes? Sure. But the changes are said to "fix" it, without success (of course, they can't succeed without doing what I outlined, that's just theoretically impossible, and OTOH not needed at all). > Stefans code does protect against that with a damping time. What do you exactly mean? > Please stop talking about your patch. I'll just omit your address from my further mail then. > Not including your patch was _without a doubt_ intentional. That's irrelevant. I haven't asked you to accept it, and I don't really know why should I. > I apologize > for being blunt: > Your patch was nothing more than a bandaid; a bad hack that was just > hiding the real problem. No, it's the opposite - that's the bandaids (not working, in fact) which try to "fix" the "race". My patch didn't include anything like that. In fact, my patch changes very little, if it's a bandaid then the current kernel is too. And stop asking me about not mentioning my patch. > I dont see any races at all in what Stefan posted- but i could be > wrong. Something new I guess. > The issue you pointed out about state flip flopping State flip-flopping? Link flip-flopping? It doesn't matter anyway. > is something that is > expected; infact the RFC talks about it and the suggested workaround is > even in current code by a little damper time and double checking the > state before announcing it to user space. You failed to understand what I meant and I'm too tired to try again and again, hope Stefan or Thomas will help you. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html