Hi Dave! On Fri, Nov 18, 2005 at 04:00:43PM -0800, David S. Miller wrote:
> I've put the patch into the net-2.6.16 tree with the obvious
> fix Eric points out.
There's another one that I detected while merging those changes with
x_tables (painful). Please merge:
[NETFILTER] arp_tables: Fix bug introduced with NUMA aware allocation
This fix shows how bad I am with copy & paste.
Signed-off-by: Harald Welte <[EMAIL PROTECTED]>
---
commit 4fa8b41b4adc117876114c149885fc8921fcabde
tree 950bd802e3daf69ad55fc203765c31ebead4fe5d
parent a7b935151849464c804437ee411dc64641c6f298
author Harald Welte <[EMAIL PROTECTED]> Sat, 19 Nov 2005 11:29:40 +0100
committer Harald Welte <[EMAIL PROTECTED]> Sat, 19 Nov 2005 11:29:40 +0100
net/ipv4/netfilter/arp_tables.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -757,7 +757,7 @@ static int translate_table(const char *n
/* And one copy for every other CPU */
for_each_cpu(i) {
if (newinfo->entries[i] && newinfo->entries[i] != entry0)
- memcpy(newinfo->entries[smp_processor_id()], entry0,
newinfo->size);
+ memcpy(newinfo->entries[i], entry0, newinfo->size);
}
return ret;
--
- Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
pgprjFpzsNlML.pgp
Description: PGP signature
