On Sun, 2005-24-07 at 23:18 -0400, Jamal Hadi Salim wrote:
> > Posting a bunch of patches that explicitly set input_dev to dev
> > right before netif_rx() sort of further proves my point :-)
> >
>
> ;->
> Let me sleep it over and think about it - I am not thinking straight
> right now. I am back home, so i should be able to dig all my notes.
>
Ok, Dave looked at my notes:
how about we set it in only ing_filter() if it is zero. i.e,
----
if (!skb->input_dev)
skb->input_dev = skb->dev->ifindex;
-----
We get rid of the printk and all other places that set input_dev except
for mirred.
Any new actions can continue to set it if they wish to. I will adapt
some of the actions i have not yet submitted to this scheme.
Thomas:
bit 0 of tc_verd can be moved into cb;
bits 2,3,4,5 MAY be moved, but it's nastier.
Whats more nasty is given how abused cb is already by dumps etc, things
could be overwritten, unless you reserve something in cb for just the
those bits.
Maybe we can have a basic temp_flags 16 or 32 bits whose scope is only
valid locally.
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
