From: Jamal Hadi Salim <[EMAIL PROTECTED]> Date: Mon, 25 Jul 2005 09:50:33 -0400
> how about we set it in only ing_filter() if it is zero. i.e, > > ---- > if (!skb->input_dev) > skb->input_dev = skb->dev->ifindex; > ----- Ok... how about we take this one step further? The idea being: 1) Put the "if (!input_dev) set_it;" code at the top of netif_receive_skb(), right before skb_bond() 2) Kill all the explicit input_dev settings for devices that we make now, ie. every case except where the actions do it With that, I'm fine with keeping skb->input_dev around since it really does have truly different semantics than real_dev did. There is, of course, still the issue of refcounting. If we go the ifindex route for skb->input_dev, it might make sense to translate device specifications in action rules into ifindex. But things could break if you down then up a device with the same name after inserting an action rule specifying that name. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
