On Wed, 4 Nov 2026 11:15:31 GMT, Michael McMahon <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix flushing in `MaxRspTimePropertyTest` > > test/jdk/com/sun/net/httpserver/property/MaxReqHeaderSizePropertyTest.java > line 160: > >> 158: int valueLength = 50 >> 159: - 2 // "k:" (key) >> 160: - OFFSET; > > Might be clearer if this was declared as a constant as the same value is used > multiple times I find header sizing already very difficult to wrap my head around. I prefer to keep these inline and verbose to aid with the cognitive load while reading the code. **Warning:** This test has been moved to #33715 & [JDK-8396660]. [JDK-8396660]: https://bugs.openjdk.org/browse/JDK-8396660 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31974#discussion_r4467820315
