On Tue, 3 Nov 2026 08:26:42 GMT, Volkan Yazici <[email protected]> wrote:
>> Add unit tests for the `jdk.httpserver` system properties. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Fix flushing in `MaxRspTimePropertyTest` test/jdk/com/sun/net/httpserver/property/IdleIntervalPropertyTest.java line 1: > 1: /* One comment (not a blocker): It looks like this test will be very long. 40s x 3 + 10 s + 1s ... With different `@test` comments and a bit of luck the bigger offenders will run in parallel, but with a default job concurrency of 4 it's not certain that they will. test/jdk/com/sun/net/httpserver/property/MaxIdleConnectionsPropertyTest.java line 1: > 1: /* Does this test open 200 concurrent sockets? I could see it becoming a source of intermittent failures on various platforms. I wonder if we shouldn't simply verify that the property "works" by supplying a reasonable value and verifying the behaviour for that value, and then simply verify the default cases by other means (e.g. retrieving field values through reflection) rather than activating the behaviour. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31974#discussion_r4455084776 PR Review Comment: https://git.openjdk.org/jdk/pull/31974#discussion_r4455268443
