On Tue, 20 Oct 2026 06:26:08 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor adjustments
>
> src/java.base/windows/native/libnio/ch/Net.c line 354:
>
>> 352: jboolean mayNeedConversion, jint
>> level, jint opt)
>> 353: {
>> 354:
>
> Spurious blank line left the last edit. (same in setIntOption0), otherwise
> this looks much better.
Addressed in the updated PR.
> src/java.base/windows/native/libnio/ch/Net.c line 361:
>
>> 359:
>> 360: if (level == IPPROTO_IPV6 && opt == IPV6_TCLASS) {
>> 361: /* No op */
>
> Maybe we should put a comment above the "if" statement to say that
> IPPROTO_IPV6/IPV6_TCLASS not supported on Windows?
Done - I removed the no-op comment and added a comment about `IPV6_TCLASS` not
being supported on Windows.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33425#discussion_r4324074148
PR Review Comment: https://git.openjdk.org/jdk/pull/33425#discussion_r4324084207
