On Mon, 19 Oct 2026 17:10:39 GMT, Alan Bateman <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   simplify checks for no-op IPV6_TCLASS
>
> src/java.base/windows/native/libnio/ch/Net.c line 406:
> 
>> 404:      /* No op */
>> 405:      return;
>> 406:     }
> 
> Can you change this to use 4-space indent and move it down to below int 
> arglen (same thing in Java_sun_nio_ch_Net_setIntOption0 so that changing of 
> the level/opts are together).

The lack of 4-space indent was an oversight. Fixed now along with moving that 
if block to after `int arglen`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33425#discussion_r4320316872

Reply via email to