On Fri, 16 Oct 2026 10:20:45 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which adds some debug logs to the > `test/jdk/java/net/SocketOption/OptionsTest.java` test? This should help > debug which socket option is causing failures in the test runs in our CI. > > I considered changing this to a junit test, but it will require much more > work and isn't straightforward. So for now, this trivial change should help > easily debug any failures. With this change, the logs will contain message > like: > > > java.net.Socket - Test SocketOption: SO_KEEPALIVE with value: true > java.net.Socket - Test SocketOption: SO_SNDBUF with value: 1000 > java.net.Socket - Test SocketOption: SO_RCVBUF with value: 800 > java.net.Socket - Test SocketOption: SO_REUSEADDR with value: false > java.net.Socket - Test SocketOption: SO_REUSEPORT with value: false > ... > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Thank you Volkan for the review. The test completed without any issues with this change on all platforms in our CI. Since this is a trivial test-only change, I'll go ahead and integrate it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33408#issuecomment-6216138327
