On Wed, 14 Oct 2026 17:20:02 GMT, Daniel Jeliński <[email protected]> wrote:
>> src/java.base/windows/native/libnet/Inet6AddressImpl.c line 30: >> >>> 28: #include "net_util.h" >>> 29: #include <iphlpapi.h> >>> 30: #include <icmpapi.h> >> >> It would be a bit clearer to group the SDK provided include files, avoid >> having the JDK header files in the midst of the system and SDK includes. > > agreed. However, the Windows header files are not standalone; icmpapi must > follow iphlpapi, and iphlpapi must follow winsock2. I took the easy route and > included iphlpapi after net_util which includes winsock2, but I can > explicitly include winsock2 too. The Windows net_util_md.h is included several header files that aren't referenced in the function prototypes, so moving them to the .c files would make it clearer. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33365#discussion_r4275293873
