On Mon, 28 Sep 2026 05:58:48 GMT, Daniel Jeliński <[email protected]> wrote:
>> In >> Java_sun_net_www_protocol_http_ntlm_NTLMAuthSequence_getCredentialsHandle, a >> CredHandle struct is allocated with a malloc call. >> But the malloced memory is never freed if later in the same function the >> AcquireCredentialsHandleA call fails. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/windows/native/libnet/NTLMAuthSequence.c line 145: > >> 143: return (jlong) pCred; >> 144: } else { >> 145: if (pCred != NULL) free(pCred); > > the NULL check is not necessary, `free` checks for NULL too. You are right, we can remove the check. But looking at the codebase https://github.com/search?q=repo%3Aopenjdk%2Fjdk+%22%29+free%28%22&type=code we seem not to trust free and still NULL-check at a lot of places; should we change this ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33070#discussion_r4135319532
