On Wed, 5 Aug 2026 11:58:12 GMT, Lee Jiwon <[email protected]> wrote:

> This adds a ServerSocket-based regression test for the case where an 
> unknown-length body publisher emits a single empty buffer.
> The test verifies that the server observes exactly one HTTP/1.1 terminal 
> chunk. 
> No production code or HTTP/2/HTTP/3 behavior is changed.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

On a general note, I don't have a strong preference, but given the kind of 
checks and errors being thrown from this test, it might be simpler to just 
create a JUnit test instead of a main() based test. The existing tests in the 
`test/jdk/java/net/httpclient` directory have several examples of how to create 
a test that uses `junit` jtreg test action.

test/jdk/java/net/httpclient/Http1RequestEmptyBufferTest.java line 46:

> 44: /**
> 45:  * @test
> 46:  * @bug 8308183

Hello @dlwldnjs1009, the jtreg section of the OpenJDK development guide has 
details about when and what values to add to the `@bug` tag 
https://openjdk.org/guide/#jtreg:

> These bug ids refer to product bugs for which a fix is verified by this test.

Since this test is verifying the fix done for 
https://bugs.openjdk.org/browse/JDK-8308024, we should use `8308024` as the 
value for `@bug` tag instead of `8308183`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32209#issuecomment-5191672172
PR Review Comment: https://git.openjdk.org/jdk/pull/32209#discussion_r3720494587

Reply via email to