On Tue, 21 Jul 2026 12:40:12 GMT, Jaikiran Pai <[email protected]> wrote:

>> Thanks for the review. That's actually a complete HTTP request, we just 
>> don't send some of its bytes. We could even use the same request in the 
>> complete request test, but that would require changing the logic to verify 
>> that we got the expected response.
>
>> That's actually a complete HTTP request, we just don't send some of its 
>> bytes.
> 
> I mistook that part then. In that case, perhaps add a comment above the 
> `RND.nextInt(1, requestBuffer.limit())` line to say something like "only send 
> a part of the HTTP request". It's just to easily spot this detail.

Good idea, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31983#discussion_r3622249320

Reply via email to