On Wed, 6 May 2026 13:40:07 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this doc-only change which updates the >> specification of `Socket.isInputShutdown()` and `Socket.isOutputShutdown()` >> to clarify how it behaves when the `Socket` has been closed? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8310138. The commit in >> this PR merely specifies the current implementation. I'll create a CSR >> shortly. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Reword the shutdownInput/Output and isInput/OutputShutdown() methods > - merge latest from master branch > - merge latest from master branch > - link instead of linkplain > - improve the text > - 8310138 Socket.isInputShutdown and isOutputShutdown don't specify what is > returned when socket is closed I spoke to Daniel about the latest text in this PR and he was OK with it. We spoke about whether or not it was OK to remove the additional text that was there in `shutdownInput()` and `shudownOutput()` methods. Given that neither the implementation in the JDK nor any specification in the Linux man pages conclusively talks about those semantics, we agreed that removing that text was OK. I have now updated (only) the specification section of the CSR https://bugs.openjdk.org/browse/JDK-8383855 to match the latest text from this PR and have now moved it to Finalized (Daniel had reviewed it previously). ------------- PR Comment: https://git.openjdk.org/jdk/pull/31000#issuecomment-4405514095
