On Tue, 14 Apr 2026 08:46:19 GMT, Volkan Yazici <[email protected]> wrote:
>> James Nord has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - 8381184: incorporate feedback
>> - Merge remote-tracking branch 'origin/master' into patch-2
>> - make the reading of URL encoding issues easier to read
>>
>> The existing documentation when rendered was hard to read for a as the
>> entire string was in a pre and rendered in the same font. Coupled with the
>> fact the the first URL would contain a space this made it hard to scan as
>> you had no visual clues and had to backtrack to re-read what the sentence
>> was trying to say.
>>
>> Switch to using inline definition using {@code} and swapped the order so
>> that the string without spaces came first negating any need for back
>> tracking when scanning
>
> src/java.base/share/classes/java/net/URL.java line 60:
>
>> 58: * following example:
>> 59: * {@snippet lang="text" :
>> 60: * http://www.example.com/docs/resource1.html
>
> I suggest removing the trailing whitespace in **all** `@snippet` content. For
> instance, I've removed the trailing whitespace from this line, and re-built
> the docs. Contrast it with the `@snippet` I've not touched below:
>
> <img width="559" height="360" alt="Image"
> src="https://github.com/user-attachments/assets/551249ab-d410-4d41-87f3-790266ec0b07";
> />
Note, this is an existing issue:
https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/net/URL.html
<img width="997" height="244" alt="Image"
src="https://github.com/user-attachments/assets/e7bfbf47-82b5-4c52-b700-4f0f4c1da713";
/>
I would say that the previous when used was probably clearer as at last the
style of the block was indented (due to the blockquaote) (the text of the block
was also indented yet again which was wrong). now neither is indented but in
this case I think we do want some indentation.
anyway, was changed as asked in 13222215d08ccf24a8767d8d05df832ed6dd06b3
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30074#discussion_r3079949595
