On Thu, 5 Mar 2026 15:23:21 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a change that refactors >> `test/jdk/java/net/httpclient/http3/H3ErrorHandlingTest.java` to use JUnit. >> >> This fix also renames `QuicStandaloneServer::addHandler` to >> `QuicStandaloneServer::setHandler` - since the method doesn't add anything >> but simply sets a variable. >> >> Finally, it also sets up `test/jdk/java/net/httpclient/TEST.properties` to >> reject `testng` actions in jtreg tests under `test/jdk/java/net/httpclient`, >> since that was the last test that needed to be converted in this test >> hierarchy. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Update test/jdk/java/net/httpclient/TEST.properties > > Co-authored-by: Christian Stein <[email protected]> test/jdk/java/net/httpclient/TEST.properties line 24: > 22: jdk.httpserver > 23: > 24: # Prevent TestNG-based tests, use @run junit actions instead The comment is not entirely correct. There's no compelling need to use `@run junit`, since traditional "`main()` based" tests are still allowed. It could then be shortened to Suggestion: # Prevent TestNG-based tests but then becomes useless, as the directive in the next line is clear enough. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30079#discussion_r2894902009
