On Wed, 4 Mar 2026 11:51:28 GMT, Daniel Fuchs <[email protected]> wrote:

>> Please find here a changeset that converts TestNG tests under 
>> `test/jdk/java/net/httpclient/http2` to JUnit.
>> 
>> This is a test-only change. Again this was mostly (but not completely) 
>> mechanical.
>
> Daniel Fuchs has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into junit-http2-8378600
>  - Review feedback: Assertions import static
>  - 8378600: Refactor tests under test/jdk/java/net/httpclient/http2 from 
> TestNG to JUnit

LGTM. Assuming that

- Tier 1-2 are clear
- Copyright years of all touched files are updated (see 
[git-license-year-violations])
- `git grep testng -- test/jdk/java/net/httpclient/http2` returns empty

[git-license-year-violations]: 
https://git.openjdk.org/jdk/pull/29900#issuecomment-3972866086

-------------

Marked as reviewed by vyazici (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30001#pullrequestreview-3889245835

Reply via email to