On Tue, 24 Feb 2026 14:21:31 GMT, Daniel Fuchs <[email protected]> wrote:
> This is a followup from https://github.com/openjdk/jdk/pull/29850, this time > converting all (but one) TestNG tests under > `test/jdk/java/net/httpclient/http3/` to use JUnit test/jdk/java/net/httpclient/http3/H3ConcurrentPush.java line 109: > 107: static final String MAIN_RESPONSE_BODY = "the main response body"; > 108: > 109: private static HttpTestServer server; Suggestion: private static HttpTestServer server; test/jdk/java/net/httpclient/http3/H3ImplicitPushCancel.java line 83: > 81: static final String MAIN_RESPONSE_BODY = "the main response body"; > 82: > 83: private static HttpTestServer server; Suggestion: private static HttpTestServer server; test/jdk/java/net/httpclient/http3/H3PushCancel.java line 97: > 95: static final String MAIN_RESPONSE_BODY = "the main response body"; > 96: > 97: private static HttpTestServer server; Suggestion: private static HttpTestServer server; test/jdk/java/net/httpclient/http3/H3ServerPushCancel.java line 113: > 111: static final int REQUESTS = 5; > 112: > 113: private static HttpTestServer server; Suggestion: private static HttpTestServer server; ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29893#discussion_r2869786113 PR Review Comment: https://git.openjdk.org/jdk/pull/29893#discussion_r2869786587 PR Review Comment: https://git.openjdk.org/jdk/pull/29893#discussion_r2869786861 PR Review Comment: https://git.openjdk.org/jdk/pull/29893#discussion_r2869786322
