On Tue, 24 Feb 2026 08:17:02 GMT, Volkan Yazici <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback: introduce actual/expected
>
> test/jdk/java/net/httpclient/DependentActionsTest.java line 253:
>
>> 251: HttpClient shared = sharedClient;
>> 252: if (shared != null) return shared;
>> 253: synchronized (zis) {
>
> I presume you opted for `zis` 😅 approach to minimize the `diff`, which makes
> sense. I don't have an objection. Alternatively, you can consider making
> `sharedClient` a `LazyConstant`, or getting it initialized in `@BeforeAll`.
>
> Note that there are more `zis` in this PR where this remark applies.
It seemed safer and less error prone than changing it to
synchronized (DependentActionsTest.class) { .. }
Due to my french accent changing `this` into `zis` was more amusing ;-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29850#discussion_r2846624294
